added support for JSONRPC libraries sending WS Message as binary #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR! This makes sense to me. And honestly the tests are a complete mess, but this library changes so infrequently I haven't bothered updating them. I've pushed up a little bit of refactoring to this branch to clean it up now that we're parsing requests from different websocket message types. Can you confirm this still works with your server? |
|
Hi Emily, Thank you again for creating this package. |
|
Thanks for your contribution! 🦄 Pushed up version 1.1.0 to pypi with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating this package. I love using it. Currently I was confronted with a JSON RPC library on server side that is sending Websocket messages of the type BINARY. Therefore I had to adapt
jsonrpc-websocketa little bit.I would be happy if the change would make it in the pip package. Unfortunately I was not able to figure out how to write a testcase for this. Maybe you can help me out.
Cheers