Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check presence of jq before installing #62

Merged
merged 1 commit into from
May 23, 2023

Conversation

yangchoo
Copy link
Contributor

what

  • Check presence of specified jq version before installing

why

  • The jq install step is observed to occasionally take up to 45s as it depends on apt update
  • This temporarily resolves the issue by checking for the presence of the specified jq version before installing

references

@yangchoo
Copy link
Contributor Author

Hmm unable to preview the error in CircleCI. I wonder if its a variable substitution issue?

I've tested locally via docker run

❯ docker run cimg/python:3.9 sudo apt show jq | grep "Version: 1.6-2.1ubuntu3" || echo "run install step"


WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Version: 1.6-2.1ubuntu3
❯ docker run cimg/python:3.9 sudo apt show jq | grep "Version: 1.6-2.1invalid" || echo "run install step"


WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

run install step

@emmeowzing
Copy link
Owner

emmeowzing commented May 23, 2023

Oh, cimg/python already has jq installed? Yeah, I like this. Good catch!

@emmeowzing emmeowzing merged commit b7ac592 into emmeowzing:master May 23, 2023
@emmeowzing emmeowzing linked an issue May 23, 2023 that may be closed by this pull request
@emmeowzing emmeowzing added the bug An issue with the system 🐛. label May 23, 2023
@emmeowzing
Copy link
Owner

@yangchoo this fix has been released with the 3.6.9 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system 🐛.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre: Install jq step is a bottleneck
2 participants