Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: render days in progress bar ETAs #1020

Merged
merged 1 commit into from Mar 20, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 20, 2024

No description provided.

@emmercm emmercm self-assigned this Mar 20, 2024
@emmercm emmercm enabled auto-merge (squash) March 20, 2024 23:21
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 93.46%. Comparing base (2063004) to head (a23e127).

Files Patch % Lines
src/console/singleBarFormatted.ts 25.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   93.56%   93.46%   -0.10%     
==========================================
  Files          91       91              
  Lines        5730     5737       +7     
  Branches     1336     1338       +2     
==========================================
+ Hits         5361     5362       +1     
- Misses        351      356       +5     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit 5a58ecb into main Mar 20, 2024
53 of 54 checks passed
@emmercm emmercm deleted the emmercm/progress-bar-eta-days branch March 20, 2024 23:27
Copy link

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/progress-bar-eta-days" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant