Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added RomM Export #1045

Merged
merged 17 commits into from
Apr 7, 2024
Merged

Feature: Added RomM Export #1045

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
660463c
Update gameConsole.ts
maxexcloo Mar 25, 2024
52f2d70
Update gameConsole.ts
maxexcloo Mar 25, 2024
296de2e
Update tokens.md
maxexcloo Mar 25, 2024
f96b2bd
Update outputFactory.ts
maxexcloo Mar 25, 2024
5fb3a67
Update mkdocs.yml
maxexcloo Mar 25, 2024
da2948e
Update argumentsParser.ts
maxexcloo Mar 25, 2024
76f2747
Update outputFactory.test.ts
maxexcloo Mar 25, 2024
b541d71
Create romm.md
maxexcloo Mar 25, 2024
db40fa2
Update outputFactory.ts
maxexcloo Mar 25, 2024
eceeba5
Update src/types/gameConsole.ts
maxexcloo Mar 26, 2024
7020e1c
Update romm.md
maxexcloo Apr 5, 2024
cc038e0
Update romm.md
maxexcloo Apr 5, 2024
f26126c
Update romm.md
emmercm Apr 7, 2024
6fc2882
Update romm.md
emmercm Apr 7, 2024
7d44263
Update outputFactory.test.ts
emmercm Apr 7, 2024
8dfc7c8
Update gameConsole.ts
emmercm Apr 7, 2024
561ea64
Merge branch 'main' into patch-2
emmercm Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/types/gameConsole.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ export default class GameConsole {
emulationstation: 'amigacd32',
jelos: 'amigacd32',
mister: 'Amiga',
onion: 'AMIGACD',
retrodeck: 'amigacd32',
romm: 'amiga-cd32',
}),
Expand Down Expand Up @@ -312,6 +313,7 @@ export default class GameConsole {
}),
new GameConsole(/VIC.*20/i, [], {
emulationstation: 'vic20',
onion: 'VIC20',
retrodeck: 'vic20',
romm: 'vic-20',
}),
Expand Down Expand Up @@ -447,7 +449,7 @@ export default class GameConsole {
emulationstation: 'msx',
mister: 'MSX',
onion: 'MSX',
retrodeck: 'msx',
retrodeck: 'msxturbor',
romm: 'msx',
}),
new GameConsole(/Xbox/i, [/* '.iso' */], {
Expand Down Expand Up @@ -538,6 +540,7 @@ export default class GameConsole {
}),
new GameConsole(/PC-FX/i, [], {
emulationstation: 'pcfx',
onion: 'PCFX',
retrodeck: 'pcfx',
romm: 'pc-fx',
}),
Expand Down Expand Up @@ -649,6 +652,7 @@ export default class GameConsole {
batocera: 'nds',
emulationstation: 'nds',
jelos: 'nds',
onion: 'NDS',
retrodeck: 'nds',
romm: 'nds',
twmenu: 'nds',
Expand All @@ -659,7 +663,7 @@ export default class GameConsole {
romm: 'nintendo-dsi',
twmenu: 'dsiware',
}), // try to map DSiWare
new GameConsole(/(\W|^)NES(\W|$)|Nintendo Entertainment System/i, ['.nes', '.nez'], {
new GameConsole(/(\W|^)NES(\W|$)|Famicom|Nintendo Entertainment System/i, ['.nes', '.nez'], {
adam: 'FC',
batocera: 'nes',
emulationstation: 'nes',
Expand Down Expand Up @@ -705,7 +709,7 @@ export default class GameConsole {
onion: 'SUFAMI',
retrodeck: 'sufami',
}),
new GameConsole(/(\W|^)SNES(\W|$)|Super Nintendo Entertainment System/i, ['.sfc', '.smc'], {
new GameConsole(/(\W|^)SNES(\W|$)|Super (Nintendo Entertainment System|Famicom)/i, ['.sfc', '.smc'], {
adam: 'SFC',
batocera: 'snes',
emulationstation: 'snes',
Expand Down Expand Up @@ -899,6 +903,7 @@ export default class GameConsole {
new GameConsole(/ZX[ -]?80/i, [], {
emulationstation: 'zx81',
mister: 'ZX81',
onion: 'ZXEIGHTYONE',
retrodeck: 'zx81',
romm: 'sinclair-zx81',
}),
Expand Down
2 changes: 1 addition & 1 deletion test/outputFactory.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ describe('token replacement', () => {
])(
'should replace {romm} for known extension: %s',
async (outputRomFilename, expectedPath) => {
const options = new Options({ commands: ['copy'], output: 'roms/{retrodeck}' });
const options = new Options({ commands: ['copy'], output: 'roms/{romm}' });
const rom = new ROM({ name: outputRomFilename, size: 0, crc32: '' });

const outputPath = OutputFactory.getPath(
Expand Down
Loading