Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: don't log the stack trace of expected errors #1203

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 8, 2024

RE: #1199

@emmercm emmercm self-assigned this Jul 8, 2024
@emmercm emmercm enabled auto-merge (squash) July 8, 2024 14:03
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 41.26984% with 37 lines in your changes missing coverage. Please review.

Project coverage is 93.16%. Comparing base (20a9ea7) to head (410799f).

Files Patch % Lines
src/types/patches/bpsPatch.ts 20.00% 4 Missing ⚠️
src/types/patches/ninjaPatch.ts 0.00% 4 Missing ⚠️
src/types/patches/ppfPatch.ts 0.00% 4 Missing ⚠️
src/types/patches/upsPatch.ts 20.00% 4 Missing ⚠️
src/types/patches/apsN64Patch.ts 0.00% 3 Missing ⚠️
src/types/patches/vcdiffPatch.ts 0.00% 3 Missing ⚠️
src/igir.ts 33.33% 2 Missing ⚠️
src/polyfill/fsPoly.ts 50.00% 2 Missing ⚠️
src/types/dats/cmpro/cmProParser.ts 0.00% 2 Missing ⚠️
src/types/files/archives/sevenZip.ts 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1203   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files         105      105           
  Lines        6486     6486           
  Branches     1530     1537    +7     
=======================================
  Hits         6043     6043           
  Misses        420      420           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 8, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/expected-error" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit ec8d897 into main Jul 8, 2024
55 checks passed
@emmercm emmercm deleted the emmercm/expected-error branch July 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant