Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: write fixdats to the output dir root #1205

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 10, 2024

Fixes: #1200

@emmercm emmercm self-assigned this Jul 10, 2024
@emmercm emmercm enabled auto-merge (squash) July 10, 2024 21:28
Copy link

github-actions bot commented Jul 10, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/fixdat-dir-root" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.15%. Comparing base (17b6860) to head (d14a9bc).

Files Patch % Lines
src/modules/fixdatCreator.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   93.16%   93.15%   -0.02%     
==========================================
  Files         105      105              
  Lines        6486     6490       +4     
  Branches     1537     1528       -9     
==========================================
+ Hits         6043     6046       +3     
+ Misses        442      421      -21     
- Partials        1       23      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit c555d9a into main Jul 11, 2024
53 of 54 checks passed
@emmercm emmercm deleted the emmercm/fixdat-dir-root branch July 11, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when using token with "copy fixdat"
1 participant