Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't leave open file handles when hashing zip entries #915

Merged
merged 2 commits into from Feb 9, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Feb 9, 2024

Fixes: #885

@emmercm emmercm self-assigned this Feb 9, 2024
@emmercm emmercm enabled auto-merge (squash) February 9, 2024 00:50
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ae85f69) 93.37% compared to head (f1b6bab) 93.39%.

Files Patch % Lines
src/types/files/archives/zip.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
+ Coverage   93.37%   93.39%   +0.01%     
==========================================
  Files          86       87       +1     
  Lines        5374     5390      +16     
  Branches     1230     1231       +1     
==========================================
+ Hits         5018     5034      +16     
  Misses        338      338              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 9, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/zip-enumerate-autodrain" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm merged commit a88e4cd into main Feb 9, 2024
52 of 53 checks passed
@emmercm emmercm deleted the emmercm/zip-enumerate-autodrain branch February 9, 2024 00:54
@emmercm emmercm mentioned this pull request Feb 9, 2024
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app crash at EMFILE: too many open files
1 participant