Add pcap example, add ixy-ci config, and fix some Virtio bugs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain VM setups filter out packets that do this which breaks our example.
The descriptor size includes the net_hdr but isn't part of the data the user receives.
Fixes the issue where packets were duplicated when the tx queue was drained (e.g. by sleeping in pktgen between batches).
|
Test passed! pktgen logsfwd logspcap logs |
|
Cool |
emmericp
requested changes
Oct 9, 2019
emmericp
requested changes
Oct 9, 2019
|
Let's just squash it into a single commit. I'd also suggest to integrate ixy-ci into this repository while we're at it. See here for how to set up the webhook. |
|
@ixy-ci test |
1 similar comment
|
@ixy-ci test |
|
Test passed! pktgen logsfwd logspcap logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the title this adds everything needed for ixy-ci and also fixes the first bugs found by it :)
The IO handling of the pcap example is rather naive and not optimized for performance so it doesn't really satisfy the README wish list entry (
tcpdump-like example based onmmap/fallocate). It does suffice for ixy-ci though.I'll manually start an ixy-ci run on this PR for demonstration purposes. Later you'll have to add a GitHub webhook for this repository to start test runs.