Fixed bug with invalid selection of previous item in CSS

emmetio · May 7, 2014 · 73ccb74 · 73ccb74
1 parent 09ba971
commit 73ccb74
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/action/selectItem.js b/lib/action/selectItem.js
@@ -383,9 +383,11 @@ define(function(require, exports, module) {
 		}
 
 		// return range next to caret
-		r = _.find(ranges, function(item) {
-			return item.end > selRange.start;
-		});
+		var test = 
+		r = _.find(ranges, isBackward 
+			? function(item) {return item.end < selRange.start;}
+			: function(item) {return item.end > selRange.start;}
+		);
 
 		if (!r) {
 			// can’t find anything, just pick first one

diff --git a/test/actions/selectItem.js b/test/actions/selectItem.js
@@ -68,6 +68,10 @@ describe('Select Next/Previous Item action', function() {
 		assert.deepEqual(next(), r(24, 38));
 		assert.deepEqual(next(), r(28, 37));
 		assert.deepEqual(next(), r(39, 48));
+
+		// edge case, previously buggy
+		editor.replaceContent('a{b:c; ${0} d:e;}');
+		assert.deepEqual(prev(), r(4, 5));
 
 		editor.setSyntax('html');
 	});