Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover publish state and menu fix #277

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Conversation

chaveiro
Copy link
Contributor

@chaveiro chaveiro commented Oct 7, 2021

#267

- Only display published dashboards on the menu to keep tidiness., replaces emoncms#268
- Remove menu show.l2, control is auto on menu sytem
@chaveiro
Copy link
Contributor Author

chaveiro commented Jul 26, 2022

@TrystanLea can you kindly solve the version conflict and merge this?

  • Menu code on this module is out of context of what should be managed exclusively by the menu lib.
    Changes on this PR are supported from emoncms 10.9.0+.

  • Also recovering the visual publish state is a very important behavior to have a clean dashboard list, function lost between 10.0 and 10.9.
    Published dashboards are visible as a link to click and view on the menu. The unpublished are considered drafts only listed on the config table.

This was referenced Jul 26, 2022
@TrystanLea TrystanLea merged commit e9be13b into emoncms:master Aug 13, 2022
@TrystanLea
Copy link
Member

Sorry all merged in, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants