New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects "Unknown" limiter path and constraint logic #611. #615

Merged

wulman16 merged 1 commit into master from bug_unexpected_behavior_unknown_date_facet_611

May 28, 2020

Contributor

bwatson78 commented May 28, 2020

render_constraints_helper.rb: initiates override of query_has_constraints? to include :range and adds two more needed methods.
_range_limit_panel.html.erb: swaps out link for method call that corrects the unknown limiter's parameters.
facet_by_year_spec.rb: bolsters the testing for facet_by_year.


          Corrects "Unknown" limiter path and constraint logic.

b55b6b7

bwatson78 mentioned this pull request

Unexpected behavior of "unknown" value in Date facet #611

Closed

Contributor Author

bwatson78 commented May 28, 2020

wulman16 approved these changes

View reviewed changes

wulman16 merged commit 11c7899 into master

wulman16 deleted the bug_unexpected_behavior_unknown_date_facet_611 branch

May 28, 2020 18:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet