Remove react native bundles for core and cache in favour of different isBrowser detection #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… isBrowser detection
🦋 Changeset is good to goLatest commit: 84bdf73 We got this. Not sure what this means? Click here to learn what changesets are. |
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
… isBrowser detection (emotion-js#1482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove react native bundles for core and cache in favour of different isBrowser detection
Why:
I want to rethink what support for the react-native field should look like in preconstruct and didn't want to have this usage of it.
How:
Change the only isBrowser check to something that preconstruct doesn't replace for browsers which in this case, I chose typeof HTMLElement
Checklist: