Accept objects as className in styled components #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 4ad7e99 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
|
Andarist
reviewed
Oct 11, 2019
Andarist
reviewed
Oct 11, 2019
|
Seems like you have uncovered a mistake in tests. This line: emotion/packages/styled/__tests__/styled.js Line 395 in a07f8a7 should use css prop and not className.
|
Andarist
reviewed
Oct 11, 2019
Andarist
reviewed
Oct 11, 2019
Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com>
Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com>
Andarist
reviewed
Oct 11, 2019
Co-Authored-By: Mateusz Burzyński <mateuszburzynski@gmail.com>
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Accept objects as className in styled components
Why: Matches react behavior per issue #1495
How: Add a special case for objects that don't already have a 'styles' property
Checklist: