Accept objects as className in jsx-created components (they are stringified) to match React behavior
#1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingified) to match React behavior
🦋 Changeset is good to goLatest commit: e5f7782 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
|
|
Once PRs get approved can we merge them right away? Or do you prefer to keep them open for some reason? |
|
You can merge them right away when they're approved, the usual reason why I don't is because I'm waiting on CI and get distracted |
|
Thanks for the reply! Roger that 😉 |
Merged
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
…ingified) to match React behavior (emotion-js#1548)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1545