Automatic hoisting. #414
Merged
Automatic hoisting. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatown
reviewed
Oct 17, 2017
| @@ -257,7 +271,7 @@ export default function(babel) { | |||
| } catch (e) { | |||
| throw path.buildCodeFrameError(e) | |||
| } | |||
|
|
|||
| hoistPureArgs(path) | |||
| path[visited] = true | |||
There was a problem hiding this comment.
This will hoist every single CallExpression
Codecov Report
|
added 2 commits
October 17, 2017 19:31
added 15 commits
October 17, 2017 19:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Hoist any arguments supplied to css or styled if they are not template literals (not sure if this matters).
Why:
Hoisting should increase the performance of inline css calls the most, but will have a secondary benefit for anyone using object styles.
How:
Use babel's
isPureandhoistmethods on thepath.Checklist: