Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMS Rails 5.1 Prework - Misc Rails 5.1 spec failures #7931

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

brendanshean
Copy link
Member

@brendanshean brendanshean commented Jul 15, 2021

WHAT

  1. Fix calls to symbolize_keys on ActionController::Parameters object
  2. Rewrite xhr controller spec requests
  3. Remove duplicate has_many declarations
  4. Update render :text calls due to deprecation

WHY

These items are all spec failures when upgrading to Rails 5.1. Fixing them before the actual upgrade makes the eventual upgrade diff more manageable.

HOW

  1. Add to_h before calling symbolize_keys
  2. change verb from xhr :get :index to get :index, xhr: true
  3. Remove duplicate
  4. Update render :text to render :plain

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

(Please provide links to any relevant Notion card(s) relevant to this PR.)

PR Checklist Your Answer
Have you added and/or updated tests? YES
Have you deployed to Staging? YES
Self-Review: Have you done an initial self-review of the code below on Github? YES
Design Review: If applicable, have you compared the coded design to the mockups? N/A

@brendanshean brendanshean changed the title Misc Rails 5.1 spec failures LMS Rails 5.1 Prework - Misc Rails 5.1 spec failures Jul 15, 2021
@brendanshean brendanshean temporarily deployed to empirical-grammar-staging2 July 15, 2021 13:47 Inactive
@brendanshean brendanshean merged commit 626a829 into develop Jul 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the bs-misc-rails-5-1-spec-failures branch July 15, 2021 14:26
brendanshean added a commit that referenced this pull request Jul 15, 2021
LMS Rails 5.1 Prework - Misc Rails 5.1 spec failures (#7931)
@brendanshean brendanshean restored the bs-misc-rails-5-1-spec-failures branch July 15, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants