fix: vector attribute issues (#402)

* fix: missing scope in vector attributes
* fix: vector attribute get after set issue

.changeset/vector-attr-events-missing-scope.md

@@ -0,0 +1,8 @@
+---
+"@empirica/core": patch
+---
+
+Fix missing scope in vector attribute callbacks.
+
+E.g.: In `Empirica.on("stage", "chat", (ctx, { stage, chat }) => {`, where
+"chat" is a vector attribute, `stage` was undefined.

.changeset/vector-attr-get-after-set-fix.md

@@ -0,0 +1,5 @@
+---
+"@empirica/core": patch
+---
+
+Fix vector attribute invalid get-after-set value.

lib/@empirica/core/src/shared/attributes.ts

@@ -260,7 +260,7 @@ export class Attribute {
   }
 
   get nodeID() {
-    return this.attr?.nodeID || this.attr?.node?.id;
+    return this.scopeID;
   }
 
   // items returns the attribute changes for the current attribute, if it is a
@@ -284,6 +284,10 @@ export class Attribute {
     ao?: Partial<AttributeOptions>,
     item?: boolean
   ): SetAttributeInput {
+    if (!item && ao?.append && ao!.index === undefined) {
+      ao!.index = this.attrs?.length || 0;
+    }
+
     if (!item && ao?.index !== undefined) {
       const index = ao!.index!;
 

lib/@empirica/core/src/shared/attributes_test.ts

@@ -395,7 +395,7 @@ test("Attribute returns nodeID", (t) => {
 
   const attr = new Attribute(setAttr, "abc", "a");
 
-  t.is(attr.nodeID, undefined);
+  t.is(attr.nodeID, "abc");
 
   attr._update({
     id: "1",