fix: game ended still ready

.changeset/game-ended-ready.md

@@ -0,0 +1,9 @@
+---
+"@empirica/core": patch
+---
+
+Ensure game and players are ready in exit steps.
+
+The presence of the game and players were not checked in the exit steps, as they
+are during the game. This could lead to the game or players not being available
+in the exit steps callback (to select the steps) or the exit steps themselves.

lib/@empirica/core/src/player/classic/react/EmpiricaContext.tsx

@@ -205,6 +205,12 @@ function Exit({
   exitSteps: React.ElementType[] | StepsFunc;
   finished: React.ElementType;
 }) {
+  const gameReady = useGameReady();
+
+  if (!gameReady) {
+    return <Loading />;
+  }
+
   return (
     <Steps progressKey="exitStep" doneKey="exitStepDone" steps={exitSteps}>
       <Finished />
@@ -246,3 +252,27 @@ function useAllReady() {
 
   return true;
 }
+
+function useGameReady() {
+  const player = usePlayer();
+  const players = usePlayers();
+  const game = useGame();
+
+  if (!player || !players || !game || !player.game) {
+    return false;
+  }
+
+  const playerCount = game.get("actualPlayerCount") as number | undefined;
+
+  if (playerCount !== undefined && players.length < playerCount) {
+    return false;
+  }
+
+  for (const p of players) {
+    if (!p.game) {
+      return false;
+    }
+  }
+
+  return true;
+}

lib/@empirica/core/tsconfig.json

@@ -15,7 +15,7 @@
     // "declarationMap": true,                /* Generates a sourcemap for each corresponding '.d.ts' file. */
     // "sourceMap": true,                     /* Generates corresponding '.map' file. */
     // "outFile": "./",                       /* Concatenate and emit output to single file. */
-    // "outDir": "./",                        /* Redirect output structure to the directory. */
+    "outDir": "./dist" /* Redirect output structure to the directory. */,
     "rootDir": "./src" /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */,
     // "composite": true,                     /* Enable project compilation */
     // "tsBuildInfoFile": "./",               /* Specify file to store incremental compilation information */
@@ -70,5 +70,6 @@
     "skipLibCheck": true /* Skip type checking of declaration files. */,
     "forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */
   },
-  "exclude": ["./pkg/**/*", "./*.config.ts"]
+  "include": ["./src/**/*"],
+  "exclude": ["./dist/**/*"]
 }