Skip to content

Commit

Permalink
fix: improve concurrency and fix various issues (#464)
Browse files Browse the repository at this point in the history
  • Loading branch information
npaton committed Dec 20, 2023
1 parent ea74918 commit a5ecdbd
Show file tree
Hide file tree
Showing 98 changed files with 10,266 additions and 14,564 deletions.
12 changes: 12 additions & 0 deletions .changeset/avoid-double-set.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"@empirica/core": patch
---

Avoid re-setting a key to the same value from the client side. For example:

```js
scope.set("key", "value");
scope.set("key", "value"); // no-op
```

This is not only for sets in the same tick as shown here, but also across ticks.
5 changes: 5 additions & 0 deletions .changeset/improve-concurrency.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@empirica/core": patch
---

Improve various concurrency issues.
5 changes: 5 additions & 0 deletions .changeset/set-introdone-once.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@empirica/core": patch
---

When <Steps> has no steps, only set the doneKey once.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ e2e-tests/test-experiment-*
e2e-tests/cache

out
.vscode
NOTES
2 changes: 2 additions & 0 deletions cmds/empirica/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@ import (
)

func main() {
// defer profile.Start(profile.ClockProfile, profile.NoShutdownHook).Stop()

cmd.Execute()
}
1 change: 0 additions & 1 deletion e2e-tests/.dockerignore

This file was deleted.

9 changes: 0 additions & 9 deletions e2e-tests/.eslintrc.js

This file was deleted.

16 changes: 0 additions & 16 deletions e2e-tests/README.md

This file was deleted.

Loading

0 comments on commit a5ecdbd

Please sign in to comment.