Fix multi-byline #24
Merged
Fix multi-byline #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: The original method of applying a "hovered" class is actually better, because when controlling in js, you can debounce. But that js logic didn't appear to make the transition to this template in the first place, so this is a starting point at least. How: **Fix typo in `post.hbs`** This typo would force the single byline every time. Now, multiple bylines are possible to render. **Fix template for `byline-multiple.hbs`** There were lots of things in here that did not get converted to Ember's flavor of HBS. I am not aware of a `#foreach` block, but it seemed broken, so I replaced one with an `#each` block and just completely removed the other one, since it would presumably merely print the authors' names, which are available on the cards.
mansona
approved these changes
May 6, 2019
|
I'm merging this even though there is a bit of an issue still, it does seem like the popups aren't working for the hover over on the multiple byline 🤔 I thought for the longest time that the Ghost demo didn't have any posts with multiple authors so we couldn't compare what it should look like but I found one https://demo.ghost.io/the-businessman-the-fisherman/ Let me know if there is anything that I can do to help to get this to work 👍 I added an example of a multiple byline to your PR so we can use it for testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
The original method of applying a "hovered" class is actually better,
because when controlling in js, you can debounce. But that js logic
didn't appear to make the transition to this template in the first
place, so this is a starting point at least.
How:
Fix typo in
post.hbsThis typo would force the single byline every time. Now, multiple
bylines are possible to render.
Fix template for
byline-multiple.hbsThere were lots of things in here that did not get converted to Ember's
flavor of HBS. I am not aware of a
#foreachblock, but it seemedbroken, so I replaced one with an
#eachblock and just completelyremoved the other one, since it would presumably merely print the
authors' names, which are available on the cards.