Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-byline #24

Merged
merged 2 commits into from
May 6, 2019
Merged

Fix multi-byline #24

merged 2 commits into from
May 6, 2019

Commits on May 6, 2019

  1. Fix multi-byline 

    Note:
The original method of applying a "hovered" class is actually better,
because when controlling in js, you can debounce. But that js logic
didn't appear to make the transition to this template in the first
place, so this is a starting point at least.

How:
**Fix typo in `post.hbs`**
This typo would force the single byline every time. Now, multiple
bylines are possible to render.

**Fix template for `byline-multiple.hbs`**
There were lots of things in here that did not get converted to Ember's
flavor of HBS. I am not aware of a `#foreach` block, but it seemed
broken, so I replaced one with an `#each` block and just completely
removed the other one, since it would presumably merely print the
authors' names, which are available on the cards.
    @happycollision
    happycollision committed May 6, 2019
    Configuration menu
    Copy the full SHA
    bf9ea26 View commit details
    Browse the repository at this point in the history

  2. adding example of multiple byline

    @mansona
    mansona committed May 6, 2019
    Configuration menu
    Copy the full SHA
    6b4e6ee View commit details
    Browse the repository at this point in the history