Exponential Auto-Reconnect #287
Conversation
|
@HJianBo, Could you pls help merge. This will save battery for iOS devices, especially who have auto-reconnect ON! Thanks in advance! |
Source/CocoaMQTT.swift
Outdated
| autoReconnTimer = CocoaMQTTTimer.every(Double(autoReconnectTimeInterval), { [weak self] in | ||
| printInfo("Try reconnect") | ||
| _ = self?.connect() | ||
| guard let weakSelf = self else { |
There was a problem hiding this comment.
This is not a weakSelf, instead, when creating this let it turns into a strongSelf.
What's the reasoning for this naming convention?
I have at least seen it once other time in the codebase
There was a problem hiding this comment.
Hi @halonsoluis, sorry for wrong convention, I will be updating it. Thanks. https://github.com/apple/swift-evolution/blob/master/proposals/0079-upgrade-self-from-weak-to-strong.md is a swift proposal, I meant to use it.
|
@HJianBo We have 2 approvals now, need your help now! |
|
Sorry guys, I am very busy in recently. I'll check it now |
|
Hi guys, I have reviewed these commits but it has some potential problems and incorrect implement for reconnecting mechanism by Unfortunately I have to open a new PR to commit it. Please to see #290 |
Hi @HJianBo, As discussed in #286.
Below is the PR, can you please review and merge?