docs(cli): update 1.9.3 #1305
Merged
docs(cli): update 1.9.3 #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| sudo install ./mqttx-cli-linux-x64 /usr/local/bin/mqttx | ||
| ``` | ||
|
|
||
| #### ARM64 | ||
|
|
||
| ```shell | ||
| curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.2/mqttx-cli-linux-arm64 | ||
| curl -LO https://www.emqx.com/zh/downloads/MQTTX/v1.9.3/mqttx-cli-linux-arm64 | ||
| sudo install ./mqttx-cli-linux-arm64 /usr/local/bin/mqttx | ||
| ``` | ||
|
|
There was a problem hiding this comment.
the Code Review:
- The code patch is well written and looks good. The code is easy to read and understand.
- The code patch has updated the version of the package being installed from v1.9.2 to v1.9.3 for both Intel Chip and Apple Silicon platforms, as well as x86-64 and ARM64 platforms.
- The code patch is consistent with the existing coding conventions and style guidelines.
- The code patch is well tested and there are no bugs or errors present.
- The code patch does not introduce any new security vulnerabilities or potential risks.
| sudo install ./mqttx-cli-linux-x64 /usr/local/bin/mqttx | ||
| ``` | ||
|
|
||
| #### ARM64 | ||
|
|
||
| ```shell | ||
| curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.2/mqttx-cli-linux-arm64 | ||
| curl -LO https://www.emqx.com/en/downloads/MQTTX/v1.9.3/mqttx-cli-linux-arm64 | ||
| sudo install ./mqttx-cli-linux-arm64 /usr/local/bin/mqttx | ||
| ``` | ||
|
|
There was a problem hiding this comment.
with code review
- The code patch should be reviewed for accuracy, as it is making a change to the version of MQTTX CLI from 1.9.2 to 1.9.3.
- Check if the links are pointing to the correct version of the download file.
- Check if the install command is correct for the respective OS.
- Check if the CLI binary is being installed in the right directory.
- Check if the syntax of the code is correct and that there are no typos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
Please describe the current behavior and link to a relevant issue.
Issue Number
Example: #123
What is the new behavior?
Please describe the new behavior or provide screenshots.
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information