Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add node version #1374

Merged
merged 3 commits into from Jul 28, 2023
Merged

chore(ci): add node version #1374

merged 3 commits into from Jul 28, 2023

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #123

What is the new behavior?

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added the chore Changes in build tools or dependent packages label Jul 27, 2023
@ysfscream ysfscream self-assigned this Jul 27, 2023
Copy link
Member

@Rory-Z Rory-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks build code in docker container, so why we need setup-node?

@ysfscream
Copy link
Member Author

Looks build code in docker container, so why we need setup-node?

Because the CI RUN Failed. But we have no idea. @Rory-Z

@Rory-Z
Copy link
Member

Rory-Z commented Jul 27, 2023

Looks build code in docker container, so why we need setup-node?

Because the CI RUN Failed. But we have no idea. @Rory-Z

Check the error log, I guess this is a node.js error ?

Copy link
Contributor

@ni00 ni00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails because the node.js version is too high and may indeed need to be limited to 16.x

@ysfscream ysfscream added this to the v1.9.5 milestone Jul 27, 2023
@ni00 ni00 merged commit 842928d into main Jul 28, 2023
1 check passed
@ni00 ni00 deleted the ysf/dev branch July 28, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes in build tools or dependent packages
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants