Add rest api #78
Merged
Add rest api #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update ReadMe |
tigercl
reviewed
Mar 30, 2019
Makefile
Outdated
|
|
||
| BUILD_DEPS = emqx cuttlefish | ||
| BUILD_DEPS = emqx cuttlefish emqx_management |
tigercl
reviewed
Mar 30, 2019
src/emqx_auth_clientid_api.erl
Outdated
|
|
||
| format([{?APP, ClientId, Password}]) -> | ||
| [{clientid, ClientId}, | ||
| {password, emqx_auth_clientid:unwap_salt(Password)}]. |
src/emqx_auth_clientid.erl
Outdated
| @@ -28,6 +28,7 @@ | |||
|
|
|||
| -export([ init/1 | |||
| , check/2 | |||
| , unwarp_salt/1 | |||
tigercl
reviewed
Mar 30, 2019
src/emqx_auth_clientid.erl
Outdated
| @@ -149,6 +150,9 @@ check(Credentials = #{client_id := ClientId, password := Password}, #{hash_type | |||
| end | |||
| end. | |||
|
|
|||
| unwarp_salt(<<_Salt:4/binary, HashPasswd/binary>>) -> | |||
HJianBo
reviewed
Mar 31, 2019
src/emqx_auth_clientid_api.erl
Outdated
| %%------------------------------------------------------------------------------ | ||
|
|
||
| return() -> | ||
| emqx_mgmt:return(). |
There was a problem hiding this comment.
- Replace this fun with
minirest:return/x - Update the minirest dependency to v0.2.2
tigercl
reviewed
Apr 1, 2019
Makefile
Outdated
| dep_emqx_passwd = git-emqx https://github.com/emqx/emqx-passwd v1.0 | ||
| dep_clique = git-emqx https://github.com/emqx/clique v0.3.11 | ||
| dep_minirest = git-emqx https://github.com/emqx/minirest v0.2.0 |
tigercl
reviewed
Apr 1, 2019
README.md
Outdated
|
|
||
| List all clientids | ||
| ``` | ||
| #Request |
There was a problem hiding this comment.
Add space between '#' and 'Request'
tigercl
reviewed
Apr 1, 2019
src/emqx_auth_clientid.erl
Outdated
| @@ -28,6 +28,7 @@ | |||
|
|
|||
| -export([ init/1 | |||
| , check/2 | |||
| , unwrap_salt/1 | |||
There was a problem hiding this comment.
move unwrap_salt/1 to single export
HJianBo
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add rest api for support
clientid CURDand add rest api test case, Introducingemqx_ct_helperin the test cases.