fix(acl): the do_check_acl function matches incorrectly

emqx · May 8, 2020 · 5c4d3d6 · 5c4d3d6
1 parent 892c9dc
commit 5c4d3d6
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/emqx_acl_mnesia.erl b/src/emqx_acl_mnesia.erl
@@ -57,15 +57,15 @@ description() -> "Acl with Mnesia".
 do_check_acl(Login, PubSub, Topic, _NoMatchAction) ->
     case emqx_auth_mnesia_cli:lookup_acl(Login) of
         [] -> ok;
+        {error, Reason} ->
+            ?LOG(error, "[Mnesia] do_check_acl error: ~p~n", [Reason]),
+            ok;
         UserAcl ->
             case match(PubSub, Topic, UserAcl) of
                 allow -> {stop, allow};
                 deny -> {stop, deny};
                 _ -> ok
-            end;
-        {error, Reason} ->
-            ?LOG(error, "[Mnesia] do_check_acl error: ~p~n", [Reason]),
-            ok
+            end
     end.
 
 match(_PubSub, _Topic, []) ->