Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inflight reference booking #132

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Fix inflight reference booking #132

merged 2 commits into from
Apr 12, 2021

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Apr 9, 2021 •
edited
Loading

fixes #81
ported from emqx/emqx#4513
and emqx/emqx#4526

Mainly 3 changes:

  1. Fixed a bug in retry_inflight which causes ack references get lost
  2. No more error level logging for unknown ack references (packet IDs for QoS > 0)
  3. Unknown ack references should not cause messages to be re-queued

@HJianBo HJianBo added this to the 4.2.10 milestone Apr 12, 2021
@HJianBo HJianBo added the bug Something isn't working label Apr 12, 2021
@HJianBo HJianBo modified the milestones: 4.2.10, 4.2.11 Apr 12, 2021
@zmstone zmstone merged commit f010752 into emqx:master Apr 12, 2021
@zmstone zmstone deleted the fix-inflight-booking branch April 12, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJianBo HJianBo HJianBo approved these changes

@turtleDeng turtleDeng Awaiting requested review from turtleDeng

@Rory-Z Rory-Z Awaiting requested review from Rory-Z

@qzhuyan qzhuyan Awaiting requested review from qzhuyan

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.2.10
Development

Successfully merging this pull request may close these issues.

"Can't be found from the inflight" log spam
2 participants
@zmstone @HJianBo