fix(import and export): add base64 for password when import and expor… #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJianBo
approved these changes
Apr 15, 2021
Rory-Z
force-pushed
the
fix/add-base64-for-password
branch
from
88372e0
to
c12717f
Compare
zmstone
reviewed
Apr 15, 2021
include/emqx_mgmt.hrl
Outdated
| -define(VERSIONS, ["1", "3.2", "3.4", "4.0", "4.0.13", "4.1", "4.2", "4.2.10"]). |
There was a problem hiding this comment.
Suggested change
| -define(VERSIONS, ["1", "3.2", "3.4", "4.0", "4.0.13", "4.1", "4.2", "4.2.10"]). | |
| -define(VERSIONS, ["4.0.13", "4.1", "4.2.10"]). |
k32
reviewed
Apr 16, 2021
src/emqx_mgmt.erl
Outdated
| _ -> is_version_supported2(Version) | ||
| end. | ||
|
|
||
| is_version_supported2("4.1") -> |
There was a problem hiding this comment.
This clause can be moved inside try lists:map(...) of to reduce the number of nested conditions. But in this case the regexp must be relaxed
k32
reviewed
Apr 16, 2021
src/emqx_mgmt.erl
Outdated
| is_version_supported2("4.1") -> | ||
| true; | ||
| is_version_supported2(Version) -> | ||
| case re:run(Version, "^4.[02].\\d+$", [{capture, none}]) of |
There was a problem hiding this comment.
Perhaps the regexp could be simplified to just "^(\\d+\\.){2}\\d+$", so it only checks format of the version, but not the version itself.
tigercl
approved these changes
Apr 16, 2021
terry-xiaoyu
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t data