Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix nil point error #1006

Merged
merged 1 commit into from Jan 25, 2024
Merged

fix: fix nil point error #1006

merged 1 commit into from Jan 25, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jan 24, 2024

When the EMQX resource is in coreNodesProgressing/replicantNodesProgressing state, if the user manually deletes currentSts/currentRs, it will cause a nil point error.

When the EMQX resource is in `coreNodesProgressing/replicantNodesProgressing` state, if the user manually deletes `currentSts/currentRs`, it will cause a nil point error.

Signed-off-by: Rory Z <16801068+Rory-Z@users.noreply.github.com>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14e0ed9) 77.00% compared to head (3ce4988) 77.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   77.00%   77.26%   +0.26%     
==========================================
  Files          67       67              
  Lines        6153     6153              
==========================================
+ Hits         4738     4754      +16     
+ Misses       1190     1175      -15     
+ Partials      225      224       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit 5cbe8df into emqx:main Jan 25, 2024
34 checks passed
@Rory-Z Rory-Z deleted the fix/fix-nil-point branch January 25, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant