Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pdb #1024

Merged
merged 1 commit into from
Mar 21, 2024
Merged

feat: add pdb #1024

merged 1 commit into from
Mar 21, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Mar 20, 2024

Fix #1023

@Rory-Z Rory-Z force-pushed the feat/add-pdb branch 6 times, most recently from 55ba967 to 059e0ef Compare March 20, 2024 03:25
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 76.73%. Comparing base (5c3cbf4) to head (51bcc28).
Report is 3 commits behind head on main.

Files Patch % Lines
controllers/apps/v2beta1/add_pdb.go 87.23% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
- Coverage   76.83%   76.73%   -0.10%     
==========================================
  Files          67       68       +1     
  Lines        6125     6173      +48     
==========================================
+ Hits         4706     4737      +31     
- Misses       1192     1206      +14     
- Partials      227      230       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rory Z <16801068+Rory-Z@users.noreply.github.com>
@Rory-Z Rory-Z merged commit 8a1e1d1 into emqx:main Mar 21, 2024
34 of 35 checks passed
@Rory-Z Rory-Z deleted the feat/add-pdb branch March 21, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ability to specify a PDB?
1 participant