refactor(emqx_sn_gateway): Ensure binary client ID #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tuple client ID has been deprecated on the previous (probably after v4.0.). However, I think it's fine to just use the ClientID here, there's no need to use a specialised Username |
HJianBo
requested changes
Nov 7, 2020
The emqx_message:make API requires first argument to be binary. Also, tuple client ID has been deprecated.
zmstone
force-pushed
the
fix-neg-qos-client-id
branch
from
4607b33
to
251a353
Compare
zmstone
changed the title
HJianBo
approved these changes
Nov 9, 2020
HJianBo
added a commit
that referenced
this pull request
Nov 9, 2020
turtleDeng
pushed a commit
that referenced
this pull request
Nov 9, 2020
HJianBo
added a commit
that referenced
this pull request
Nov 9, 2020
HJianBo
added a commit
that referenced
this pull request
Nov 10, 2020
tigercl
pushed a commit
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
emqx_message:makeAPI requires first argument to be binary.Not entirely sure if this tuple client ID has its special use case though.