Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow get and delete #220

Merged
merged 3 commits into from
Oct 24, 2020
Merged

Conversation

6293
Copy link
Contributor

@6293 6293 commented Oct 23, 2020

Enabled get / delete request with the actions in Rule Engine.
This feature is especially useful when EMQX broker is working as a proxy from IoT devices to a REST API server.

@HJianBo HJianBo added this to the 4.2.2 milestone Oct 23, 2020
@@ -37,7 +37,7 @@
description => #{en => <<"Request Header">>,
zh => <<"请求头"/utf8>>}},
method => #{type => string,
enum => [<<"PUT">>,<<"POST">>],
enum => [<<"PUT">>,<<"POST">>,<<"GET">>,<<"DELETE">>],
default => <<"POST">>,
title => #{en => <<"Request Method">>,
zh => <<"请求方法"/utf8>>},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a note in the description I think:

description => #{en => <<"Request Method. Note that the payload_template will be discarded in case of GET method">>,
                           zh => <<"请求方法。注意:当请求方法为 GET 的时候,payload_template 参数会被忽略"/utf8>>}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

@terry-xiaoyu terry-xiaoyu merged commit def9314 into emqx:dev/v4.2.2 Oct 24, 2020
@terry-xiaoyu
Copy link
Contributor

@z8674558 This will be included in 4.2.2, Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants