Merge pull request #12278 from lafirest/fix/limit

fix(api): adjust the maximum limit of page query to 10,000
emqx · Jan 10, 2024 · 3d7264c · 3d7264c
2 parents adcda51 + 4e046ea
commit 3d7264c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/apps/emqx_dashboard/src/emqx_dashboard.app.src b/apps/emqx_dashboard/src/emqx_dashboard.app.src
@@ -2,7 +2,7 @@
 {application, emqx_dashboard, [
     {description, "EMQX Web Dashboard"},
     % strict semver, bump manually!
-    {vsn, "5.0.31"},
+    {vsn, "5.0.32"},
     {modules, []},
     {registered, [emqx_dashboard_sup]},
     {applications, [

diff --git a/apps/emqx_dashboard/src/emqx_dashboard_swagger.erl b/apps/emqx_dashboard/src/emqx_dashboard_swagger.erl
@@ -83,7 +83,7 @@
 
 -define(SPECIAL_LANG_MSGID, <<"$msgid">>).
 
--define(MAX_ROW_LIMIT, 1000).
+-define(MAX_ROW_LIMIT, 10000).
 -define(DEFAULT_ROW, 100).
 
 -type request() :: #{bindings => map(), query_string => map(), body => map()}.

diff --git a/apps/emqx_dashboard/test/emqx_swagger_parameter_SUITE.erl b/apps/emqx_dashboard/test/emqx_swagger_parameter_SUITE.erl
@@ -140,13 +140,13 @@ t_public_ref(_Config) ->
     ExpectRefs = [
         #{
             <<"public.limit">> => #{
-                description => <<"Results per page(max 1000)">>,
+                description => <<"Results per page(max 10000)">>,
                 in => query,
                 name => limit,
                 example => 50,
                 schema => #{
                     default => 100,
-                    maximum => 1000,
+                    maximum => 10000,
                     minimum => 1,
                     type => integer
                 }

diff --git a/changes/ce/feat-12278.en.md b/changes/ce/feat-12278.en.md
@@ -0,0 +1 @@
+In the REST API, the maximum limit of page queries is adjusted to 10,000.