Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off kafka bridge default mem olp #10007

Merged

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Feb 21, 2023

fixes: EMQX-8996

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • [~] Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/<version>/(feat|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
  • [~] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

id
id previously approved these changes Feb 21, 2023
@zmstone zmstone force-pushed the 0221-turn-off-kafka-bridge-default-mem-olp branch from 5bc1e4a to 6cab97e Compare February 21, 2023 07:59
@zmstone zmstone marked this pull request as ready for review February 21, 2023 08:03
@zmstone zmstone requested a review from a team as a code owner February 21, 2023 08:03
changes/ee/fix-10007.en.md Outdated Show resolved Hide resolved
changes/ee/fix-10007.en.md Outdated Show resolved Hide resolved
changes/ee/fix-10007.en.md Outdated Show resolved Hide resolved
id
id previously approved these changes Feb 22, 2023
@zmstone zmstone merged commit 418f397 into emqx:master Feb 22, 2023
@zmstone zmstone deleted the 0221-turn-off-kafka-bridge-default-mem-olp branch February 22, 2023 21:28
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4242843677

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 26 unchanged lines in 10 files lost coverage.
  • Overall coverage remained the same at 80.776%

Files with Coverage Reduction New Missed Lines %
apps/emqx_dashboard/src/emqx_dashboard_monitor.erl 1 69.44%
apps/emqx/src/emqx_channel.erl 1 87.58%
apps/emqx/src/emqx_cm.erl 1 90.83%
apps/emqx/src/emqx_limiter/src/emqx_limiter_server.erl 1 89.08%
apps/emqx/src/emqx_router_helper.erl 1 86.27%
apps/emqx_connector/src/emqx_connector_jwt_worker.erl 2 92.54%
apps/emqx/src/emqx_config_handler.erl 2 96.21%
apps/emqx/src/emqx_quic_connection.erl 2 78.57%
apps/emqx_gateway/src/mqttsn/emqx_sn_frame.erl 3 63.48%
apps/emqx/src/emqx_reason_codes.erl 12 89.71%
Totals Coverage Status
Change from base Build 4241994879: 0.0%
Covered Lines: 23951
Relevant Lines: 29651

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants