Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(quic): changelog and remove dup quic field #10037

Merged
merged 4 commits into from Feb 28, 2023
Merged

chore(quic): changelog and remove dup quic field #10037

merged 4 commits into from Feb 28, 2023

Conversation

qzhuyan
Copy link
Contributor

@qzhuyan qzhuyan commented Feb 27, 2023 •
edited

fix: #10031

@qzhuyan qzhuyan changed the base branch from master to release-50 February 27, 2023 22:40
@qzhuyan
Copy link
Contributor Author

qzhuyan commented Feb 27, 2023

Need to add some TCs to test the following API endpoints:

api-docs/swagger.json 
api-docs/index.html

Also, hidden fields shall not get exported via swagger.

HJianBo
HJianBo previously approved these changes Feb 28, 2023
View reviewed changes
zmstone
zmstone previously approved these changes Feb 28, 2023
View reviewed changes
@qzhuyan qzhuyan dismissed stale reviews from zmstone and HJianBo via a980a3b February 28, 2023 08:19
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4290959476

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.03%) to 80.833%
Files with Coverage Reduction New Missed Lines %
apps/emqx_conf/src/emqx_conf_schema.erl 1 92.86%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 1 93.15%
apps/emqx/src/emqx_authentication_config.erl 1 81.25%
apps/emqx/src/emqx_connection.erl 1 87.96%
apps/emqx/src/emqx_quic_data_stream.erl 1 75.21%
apps/emqx/src/emqx_schema.erl 1 90.91%
apps/emqx/src/emqx_channel.erl 2 87.58%
apps/emqx_resource/src/emqx_resource_metrics.erl 5 74.07%
apps/emqx/src/emqx_sys_mon.erl 5 86.46%
apps/emqx/src/emqx_reason_codes.erl 10 91.91%
Totals Coverage Status
Change from base Build 4282483498: 0.03%
Covered Lines: 24060
Relevant Lines: 29765
💛 - Coveralls

@qzhuyan qzhuyan marked this pull request as ready for review February 28, 2023 09:24
@qzhuyan qzhuyan requested review from a team and lafirest as code owners February 28, 2023 09:24
zmstone
zmstone reviewed Feb 28, 2023
View reviewed changes
changes/ce/fix-10037.en.md Outdated Show resolved Hide resolved
zmstone
zmstone reviewed Feb 28, 2023
View reviewed changes
changes/ce/fix-10037.zh.md Outdated Show resolved Hide resolved
thalesmg
thalesmg previously approved these changes Feb 28, 2023
View reviewed changes
@qzhuyan
Copy link
Contributor Author

qzhuyan commented Feb 28, 2023

rebased, get rid of flaky OLP tests.

@qzhuyan qzhuyan merged commit 2b26a31 into emqx:release-50 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone approved these changes

@ieQu1 ieQu1 ieQu1 approved these changes

@HJianBo HJianBo HJianBo left review comments

@thalesmg thalesmg thalesmg left review comments

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qzhuyan @coveralls @zmstone @HJianBo @thalesmg @ieQu1