Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emqx_mgmt): format stoped nodes correctly #10044

Merged
merged 4 commits into from Mar 1, 2023

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Feb 28, 2023

fixes: #10034

overview:

image

node view:

image

sample output

[
  {
    "connections": 0,
    "edition": "Opensource",
    "load1": 0.6,
    "load15": 0.89,
    "load5": 1.01,
    "log_path": "log.file_handler.default.enable is false, not logging to file",
    "max_fds": 1048576,
    "memory_total": "62.75G",
    "memory_used": "10.92G",
    "node": "emqx@node2.emqx.io",
    "node_status": "running",
    "otp_release": "24.3.4.2-2/12.3.2.2",
    "process_available": 2097152,
    "process_used": 625,
    "role": "core",
    "sys_path": "/opt/emqx",
    "uptime": 97457,
    "version": "5.0.18-ge8427c99"
  },
  {
    "node": "emqx@node1.emqx.io",
    "node_status": "stopped"
  }
]

@zmstone zmstone requested review from a team, lafirest and sstrigler as code owners February 28, 2023 20:36
ieQu1
ieQu1 previously approved these changes Feb 28, 2023
thalesmg
thalesmg previously approved these changes Feb 28, 2023
@zmstone zmstone dismissed stale reviews from thalesmg and ieQu1 via 469071d March 1, 2023 06:46
changes/ce/fix-10044.zh.md Outdated Show resolved Hide resolved
Co-authored-by: William Yang <mscame@gmail.com>
iolist_to_binary(filename:join(RootDir, Path))
end.

get_log_path([#{config := #{file := Path}} | _LoggerConfigs]) ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes we only have one logger handler that has file backend.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not assume that, it returns the first one.

@zmstone zmstone merged commit fdc0ad6 into emqx:release-50 Mar 1, 2023
@zmstone zmstone deleted the 0228-fix-node-info-format branch March 1, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants