New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(emqx_mgmt): format stoped nodes correctly #10044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
0228-fix-node-info-format
branch
from
February 28, 2023 20:38
3cb3cfd
to
d369e31
Compare
ieQu1
previously approved these changes
Feb 28, 2023
thalesmg
previously approved these changes
Feb 28, 2023
qzhuyan
reviewed
Mar 1, 2023
Co-authored-by: William Yang <mscame@gmail.com>
qzhuyan
reviewed
Mar 1, 2023
iolist_to_binary(filename:join(RootDir, Path)) | ||
end. | ||
|
||
get_log_path([#{config := #{file := Path}} | _LoggerConfigs]) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes we only have one logger handler that has file backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not assume that, it returns the first one.
qzhuyan
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #10034
overview:
node view:
sample output