fix: consistently return 404 in case bridge is not found or invalid #10050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: fix some typos and be more verbose
sstrigler
force-pushed
the
EMQX-9063-bridges-api-consistently-return-404-if-resource-does-not-exist
branch
from
51abcdd
to
3f324f8
Compare
sstrigler
commented
Mar 1, 2023
thalesmg
previously approved these changes
Mar 1, 2023
savonarola
reviewed
Mar 2, 2023
savonarola
reviewed
Mar 2, 2023
savonarola
approved these changes
Mar 2, 2023
id
approved these changes
Mar 2, 2023
sstrigler
deleted the
EMQX-9063-bridges-api-consistently-return-404-if-resource-does-not-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: fix some typos and be more verbose
Fixes EMQX-9063
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdand.zh.mdfiles[ ] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up[ ] Schema changes are backward compatible