Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n desc of broker_shared_subscription_strategy #10079

Conversation

qzhuyan
Copy link
Contributor

@qzhuyan qzhuyan commented Mar 6, 2023

Fix: EMQX-9007

I just fetched the description from old commits.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

Added tests for the changes
Changed lines covered in coverage report

  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
    If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
    Schema changes are backward compatible

@qzhuyan qzhuyan force-pushed the fix/william/i18n-broker_shared_subscription_strategy branch from d7e5373 to 1912027 Compare March 6, 2023 15:28
@qzhuyan qzhuyan marked this pull request as ready for review March 7, 2023 08:16
@qzhuyan qzhuyan requested review from a team and lafirest as code owners March 7, 2023 08:16
@zmstone zmstone merged commit 158b4a9 into emqx:master Mar 7, 2023

zh: """共享订阅消息派发策略。
- `random`:随机挑选一个共享订阅者派发;
- `round_robin`:使用 round-robin 策略派发;
- `round_robin_per_group`: 在共享组内循环选择下一个成员;
- `local`: 选择随机的本地成员,否则选择随机的集群范围内成员;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Copy link
Contributor

@LenaLenaPan LenaLenaPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some comments

- `sticky`:总是使用上次选中的订阅者派发,直到它断开连接;
- `hash`:使用发送者的 Client ID 进行 Hash 来选择订阅者。"""
- `hash_clientid`:使用发送者的 Client ID 进行 Hash 来选择订阅者;
- `hash_topic`: 使用源主题进行 Hash 来选择订阅者。"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

通过对源主题进行 Hash 处理来选择订阅者

- `sticky`:总是使用上次选中的订阅者派发,直到它断开连接;
- `hash`:使用发送者的 Client ID 进行 Hash 来选择订阅者。"""
- `hash_clientid`:使用发送者的 Client ID 进行 Hash 来选择订阅者;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

通过对发送者的客户端 ID 进行 Hash 处理来选择订阅者

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments are addressed in #10284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants