Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to ehttpc 0.4.7 #10086

Merged
merged 2 commits into from Mar 8, 2023

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Mar 7, 2023

Fixes EMQX-8974

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • [~] Added tests for the changes
  • [~] Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
  • [~] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • [~] Schema changes are backward compatible

@zmstone zmstone requested a review from a team as a code owner March 7, 2023 16:49
@zmstone zmstone marked this pull request as draft March 7, 2023 18:33
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4356505127

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 38 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.03%) to 80.823%

Files with Coverage Reduction New Missed Lines %
apps/emqx_gateway/src/mqttsn/emqx_sn_frame.erl 1 63.48%
apps/emqx/src/emqx_flapping.erl 1 85.11%
apps/emqx/src/emqx_session.erl 1 87.6%
apps/emqx/src/emqx_stats.erl 1 91.67%
apps/emqx_dashboard/src/emqx_dashboard_monitor.erl 2 68.06%
apps/emqx/src/emqx_cm.erl 2 91.28%
apps/emqx/src/emqx_channel.erl 4 87.27%
apps/emqx/src/emqx_sys_mon.erl 5 86.46%
apps/emqx/src/emqx_reason_codes.erl 21 83.09%
Totals Coverage Status
Change from base Build 4354409766: -0.03%
Covered Lines: 24107
Relevant Lines: 29827

💛 - Coveralls

@kjellwinblad
Copy link
Contributor

Here are steps to reproduce the original issue that is fixed by this PR:

  1. Create a webhook bridge with:
    • header "content-type: text/html"
    • empty body
    • request type can be POST but I think one can reproduce it with the other request types as well
    • set all pool sizes (buffer worker pool and connection pool) to one to make sure all requests go to the same gun connection
    • Set up a rule that listen to a topic and connect it to the webhook bridge
  2. Send two messages to the rule's topic
  3. You should know see the error log message provided in the Jira issue in the log file

@zmstone zmstone marked this pull request as ready for review March 8, 2023 11:56
@zmstone zmstone force-pushed the 0307-upgrade-to-ehttpc-0.4.7 branch from 3128167 to ac6325c Compare March 8, 2023 11:56
@zmstone zmstone merged commit 2825958 into emqx:release-50 Mar 8, 2023
@zmstone zmstone deleted the 0307-upgrade-to-ehttpc-0.4.7 branch March 8, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants