Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel crash for slow clients with enhanced authentication #10100

Merged
merged 1 commit into from Mar 10, 2023

Conversation

savonarola
Copy link
Contributor

Also gracefully handle Authentication-Data absence.

@coveralls
Copy link
Collaborator

coveralls commented Mar 8, 2023

Pull Request Test Coverage Report for Build 4376043824

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 41 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.04%) to 80.829%

Files with Coverage Reduction New Missed Lines %
apps/emqx_authn/src/enhanced_authn/emqx_enhanced_authn_scram_mnesia.erl 1 88.06%
apps/emqx_bridge/src/emqx_bridge.erl 1 89.6%
apps/emqx_gateway/src/mqttsn/emqx_sn_channel.erl 1 73.13%
apps/emqx_machine/src/emqx_machine.erl 1 77.42%
apps/emqx_resource/src/emqx_resource_manager.erl 1 92.04%
apps/emqx/src/emqx_broker.erl 1 85.96%
apps/emqx/src/emqx_channel.erl 1 87.6%
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_session.erl 1 87.6%
apps/emqx/src/emqx_stats.erl 1 91.67%
Totals Coverage Status
Change from base Build 4362708326: -0.04%
Covered Lines: 24235
Relevant Lines: 29983

💛 - Coveralls

@savonarola savonarola marked this pull request as ready for review March 9, 2023 11:53
@savonarola savonarola requested review from a team, JimMoen and lafirest as code owners March 9, 2023 11:53
@savonarola
Copy link
Contributor Author

Coverage decreased although all new lines are covered 🤷

changes/ce/fix-10100.zh.md Outdated Show resolved Hide resolved
changes/ce/fix-10100.en.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants