Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace env value string to binary #10130

Merged
merged 3 commits into from
Mar 15, 2023
Merged

fix: replace env value string to binary #10130

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc2ddc6
chore: add changelog for configuration information on Dashboard is ga…
zhongwencool Mar 15, 2023
60677bc
chore: remove unuse code
zhongwencool Mar 15, 2023
597bfbe
chore: update changes/ce/fix-10130.en.md
zhongwencool Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/emqx_management/src/emqx_mgmt_api_configs.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
<<"authorization">>,
<<"authentication">>,
<<"rpc">>,
<<"db">>,
<<"connectors">>,
<<"slow_subs">>,
<<"psk_authentication">>,
Expand Down
12 changes: 0 additions & 12 deletions apps/emqx_plugins/src/emqx_plugins_sup.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,6 @@ start_link() ->
supervisor:start_link({local, ?MODULE}, ?MODULE, []).

init([]) ->
%% TODO: Add monitor plugins change.
Monitor = emqx_plugins_monitor,
_Children = [
#{
id => Monitor,
start => {Monitor, start_link, []},
restart => permanent,
shutdown => brutal_kill,
type => worker,
modules => [Monitor]
}
],
SupFlags =
#{
strategy => one_for_one,
Expand Down
4 changes: 4 additions & 0 deletions changes/ce/fix-10130.en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix the EMQX node started by environment variable configuration cannot get the correct configuration information through HTTP API.
For example: `EMQX_STATSD__SERVER='127.0.0.1:8124' . /bin/emqx start`
and the Statsd configuration information on Dashboard is garbled (not '127.0.0.1:8124').
Related PR: [HOCON:234](https://github.com/emqx/hocon/pull/234).
zhongwencool marked this conversation as resolved.
Show resolved Hide resolved
3 changes: 3 additions & 0 deletions changes/ce/fix-10130.zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
修复通过环境变量配置启动的 EMQX 节点无法通过HTTP API获取到正确的配置信息。
比如：`EMQX_STATSD__SERVER='127.0.0.1:8124' ./bin/emqx start` 后通过 Dashboard看到的 Statsd 配置信息是乱码。
相关 PR: [HOCON:234](https://github.com/emqx/hocon/pull/234).