Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle escaped characters in InfluxDB data bridge write_syntax #10165

Conversation

SergeTupchiy
Copy link
Contributor

@SergeTupchiy SergeTupchiy commented Mar 17, 2023

Closes: EMQX-7834

Fixes https://emqx.atlassian.net/browse/EMQX-7834

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@SergeTupchiy SergeTupchiy force-pushed the EMQX-7834-influx-db-bridge-support-escaped-chars-in-write-syntax branch from 50077a3 to 544f855 Compare March 17, 2023 18:49
@SergeTupchiy SergeTupchiy marked this pull request as ready for review March 17, 2023 21:10
@SergeTupchiy SergeTupchiy requested a review from a team as a code owner March 17, 2023 21:10
@SergeTupchiy SergeTupchiy force-pushed the EMQX-7834-influx-db-bridge-support-escaped-chars-in-write-syntax branch from 544f855 to 5da59cb Compare March 20, 2023 10:51
@coveralls
Copy link
Collaborator

coveralls commented Mar 20, 2023

Pull Request Test Coverage Report for Build 4469493788

  • 58 of 58 (100.0%) changed or added relevant lines in 1 file are covered.
  • 49 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.03%) to 80.89%

Files with Coverage Reduction New Missed Lines %
apps/emqx_modules/src/emqx_delayed.erl 1 94.78%
apps/emqx_resource/src/emqx_resource_manager.erl 1 90.48%
apps/emqx/src/emqx_broker.erl 1 88.2%
apps/emqx/src/emqx_cm.erl 1 91.44%
apps/emqx/src/emqx_quic_stream.erl 1 75.0%
apps/emqx/src/emqx_ws_connection.erl 1 79.4%
lib-ee/emqx_ee_connector/src/emqx_ee_connector_influxdb.erl 1 90.05%
apps/emqx_connector/src/emqx_connector_jwt_worker.erl 2 92.54%
apps/emqx_resource/src/emqx_resource_buffer_worker_sup.erl 2 86.96%
apps/emqx/src/emqx_alarm.erl 2 91.89%
Totals Coverage Status
Change from base Build 4464188731: -0.03%
Covered Lines: 24674
Relevant Lines: 30503

💛 - Coveralls

@SergeTupchiy SergeTupchiy force-pushed the EMQX-7834-influx-db-bridge-support-escaped-chars-in-write-syntax branch from 5da59cb to 3a46681 Compare March 20, 2023 14:44
@SergeTupchiy SergeTupchiy merged commit 8e7f884 into emqx:master Mar 20, 2023
98 of 99 checks passed
@SergeTupchiy SergeTupchiy deleted the EMQX-7834-influx-db-bridge-support-escaped-chars-in-write-syntax branch April 21, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants