Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add summary to schemas where description has html #10195

Conversation

sstrigler
Copy link
Contributor

@sstrigler sstrigler commented Mar 21, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-8982

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • [-] Added tests for the changes
  • [-] Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • [-] If changed package build workflow, pass this action (manual trigger)
  • [-] Change log has been added to changes/ dir for user-facing artifacts update

@sstrigler sstrigler marked this pull request as ready for review March 21, 2023 15:15
@sstrigler sstrigler requested review from a team, lafirest and JimMoen as code owners March 21, 2023 15:15
ieQu1
ieQu1 previously approved these changes Mar 21, 2023
@sstrigler sstrigler force-pushed the EMQX-8982-html-tags-are-displayed-in-http-api-doc branch from 28ad976 to a5637cc Compare March 21, 2023 18:43
@sstrigler sstrigler force-pushed the EMQX-8982-html-tags-are-displayed-in-http-api-doc branch from 33c712d to 0829445 Compare March 22, 2023 12:34
sstrigler added a commit to emqx/emqx-docs that referenced this pull request Mar 22, 2023
@sstrigler sstrigler force-pushed the EMQX-8982-html-tags-are-displayed-in-http-api-doc branch from 0829445 to 678400b Compare March 23, 2023 15:41
@sstrigler sstrigler requested a review from zmstone March 23, 2023 16:48
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4502457699

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.07%) to 81.007%

Files with Coverage Reduction New Missed Lines %
apps/emqx_gateway/src/mqttsn/emqx_sn_channel.erl 1 73.13%
apps/emqx/src/emqx_channel.erl 1 87.64%
apps/emqx/src/emqx_cm.erl 1 91.44%
apps/emqx/src/emqx_ws_connection.erl 1 79.4%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 2 91.46%
apps/emqx/src/emqx_flapping.erl 3 80.85%
apps/emqx/src/emqx_reason_codes.erl 10 88.97%
Totals Coverage Status
Change from base Build 4501388374: 0.07%
Covered Lines: 24883
Relevant Lines: 30717

💛 - Coveralls

@sstrigler sstrigler merged commit 4f63982 into emqx:master Mar 24, 2023
101 checks passed
@sstrigler sstrigler deleted the EMQX-8982-html-tags-are-displayed-in-http-api-doc branch March 24, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants