Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMQX-9101 mnesia unregister hook #10210

Merged

Conversation

SergeTupchiy
Copy link
Contributor

@SergeTupchiy SergeTupchiy commented Mar 22, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-9111

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@SergeTupchiy SergeTupchiy force-pushed the EMQX-9101-mnesia-unregister-hook branch from 78edc8a to 8f5b3c6 Compare March 22, 2023 19:56
@SergeTupchiy SergeTupchiy marked this pull request as ready for review March 22, 2023 19:58
Rory-Z
Rory-Z previously approved these changes Mar 23, 2023
These OTP versions implement mnesia_hook:unregister_hook/1
ekka 0.14.6 uses mria 0.4.2, which unregisters mnesia_hook upon stopping mria.
This fixes mnesia_hook errors on restarting mria.

Closes: EMQX-9101
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4499282773

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.007%) to 80.955%

Files with Coverage Reduction New Missed Lines %
apps/emqx_gateway/src/mqttsn/emqx_sn_frame.erl 1 63.48%
apps/emqx_machine/src/emqx_machine.erl 1 77.42%
apps/emqx_rule_engine/src/emqx_rule_engine.erl 1 85.83%
apps/emqx/src/emqx_quic_data_stream.erl 1 75.21%
apps/emqx/src/emqx_session.erl 1 87.25%
apps/emqx/src/emqx_crl_cache.erl 2 90.11%
apps/emqx/src/emqx_logger_textfmt.erl 2 56.82%
apps/emqx/src/emqx_channel.erl 3 87.17%
apps/emqx/src/emqx_reason_codes.erl 11 89.71%
Totals Coverage Status
Change from base Build 4498490026: -0.007%
Covered Lines: 24862
Relevant Lines: 30711

💛 - Coveralls

@SergeTupchiy SergeTupchiy merged commit 5a14d08 into emqx:master Mar 23, 2023
100 checks passed
@SergeTupchiy SergeTupchiy deleted the EMQX-9101-mnesia-unregister-hook branch April 21, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants