Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add option to customize clusterIP #10224

Merged
merged 2 commits into from Mar 29, 2023

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Mar 23, 2023

Fixes #10223

https://emqx.atlassian.net/browse/EMQX-9300

Adds an option to set clusterIP to a fixed IP if the user wants that.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg marked this pull request as ready for review March 23, 2023 15:24
@thalesmg thalesmg requested review from a team and Rory-Z as code owners March 23, 2023 15:24
Fixes emqx#10223

Adds an option to set `clusterIP` to a fixed IP if the user wants
that.
@coveralls
Copy link
Collaborator

coveralls commented Mar 24, 2023

Pull Request Test Coverage Report for Build 4532806608

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 188 unchanged lines in 24 files lost coverage.
  • Overall coverage increased (+0.0007%) to 80.93%

Files with Coverage Reduction New Missed Lines %
apps/emqx_authn/src/enhanced_authn/emqx_enhanced_authn_scram_mnesia.erl 1 86.57%
apps/emqx_bridge/src/emqx_bridge_resource.erl 1 72.57%
apps/emqx_conf/src/emqx_cluster_rpc.erl 1 80.31%
apps/emqx_machine/src/emqx_machine.erl 1 77.42%
apps/emqx/src/emqx_cm.erl 1 91.89%
apps/emqx/src/emqx_config.erl 1 87.5%
apps/emqx/src/emqx_connection.erl 1 88.24%
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_quic_stream.erl 1 75.0%
apps/emqx/src/emqx_sys_mon.erl 1 91.67%
Totals Coverage Status
Change from base Build 4509125669: 0.0007%
Covered Lines: 24962
Relevant Lines: 30844

💛 - Coveralls

Co-authored-by: Zaiming (Stone) Shi <zmstone@gmail.com>
@thalesmg thalesmg merged commit 6e596ec into emqx:master Mar 29, 2023
100 checks passed
@thalesmg thalesmg deleted the helm-cluster-ip branch March 29, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes helm config
3 participants