fix: create consistent interface 'with_node' for API access #10237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstrigler
force-pushed
the
EMQX-9138-e-5-0-2-ensure-that-the-error-messages-returned-are-consistent
branch
4 times, most recently
from
6bfc286
to
ccfd3f4
Compare
ieQu1
reviewed
Mar 27, 2023
sstrigler
force-pushed
the
EMQX-9138-e-5-0-2-ensure-that-the-error-messages-returned-are-consistent
branch
from
ccfd3f4
to
0017be3
Compare
savonarola
reviewed
Mar 27, 2023
| -ifndef(EMQX_API_LIB_HRL). | ||
| -define(EMQX_API_LIB_HRL, true). | ||
|
|
||
| -define(ERROR_MSG(CODE, REASON), #{code => CODE, message => emqx_misc:readable_error_msg(REASON)}). |
There was a problem hiding this comment.
(Maybe for future discussion): I always wondered why we should have all the responses as macros. We do not match against them anywhere, and the performance impact should be neglectable 🤔
There was a problem hiding this comment.
I think it vastly improves readability and consistency, my goal rather is to ONLY use those macros throughout than constructing all those responses by hand.
Or is it, that you would favor function calls instead?
There was a problem hiding this comment.
(Also I match against them in my tests)
There was a problem hiding this comment.
that you would favor function calls instead?
Yes, I mean
error_msg(Code, Reason) ->
...
vs
-define(ERROR_MSG(CODE, REASON), ...).
savonarola
previously approved these changes
Mar 27, 2023
sstrigler
force-pushed
the
EMQX-9138-e-5-0-2-ensure-that-the-error-messages-returned-are-consistent
branch
from
0017be3
to
64a1d84
Compare
lafirest
reviewed
Mar 28, 2023
lafirest
approved these changes
Mar 28, 2023
ieQu1
approved these changes
Mar 28, 2023
sstrigler
deleted the
EMQX-9138-e-5-0-2-ensure-that-the-error-messages-returned-are-consistent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-9138
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdand.zh.mdfiles