Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0330 exit with non zero code if conf init failed #10286

Merged
merged 5 commits into from Mar 30, 2023
Merged

0330 exit with non zero code if conf init failed #10286

merged 5 commits into from Mar 30, 2023

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Mar 30, 2023 •
edited

Fixes https://emqx.atlassian.net/browse/EMQX-9421

The init:stop() was made in this PR: https://github.com/emqx/emqx/pull/10211/files#diff-ad5a2cb24f84268ad38b0d2794bba9cd8f54fb0913a2dce30fa590e441975d7e
which is not released ye.t.
This PR fixes the exit status code, also add changelogs for it.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • [~] Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md and .zh.md files
  • For internal contributor: there is a jira ticket to track this change
  • [~] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • [~] Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • [~] If changed package build workflow, pass this action (manual trigger)
  • [~] Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested review from a team and lafirest as code owners March 30, 2023 12:12
savonarola
savonarola previously approved these changes Mar 30, 2023
View reviewed changes
thalesmg
thalesmg previously approved these changes Mar 30, 2023
View reviewed changes
changes/ce/fix-10286.en.md Outdated Show resolved Hide resolved
@zmstone @thalesmg
docs: Update changes/ce/fix-10286.en.md
14039e3 
Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
@zmstone zmstone dismissed stale reviews from thalesmg and savonarola via 14039e3 March 30, 2023 15:11
@zmstone zmstone merged commit 36043dd into emqx:master Mar 30, 2023
94 of 98 checks passed
@zmstone zmstone deleted the 0330-exit-with-non-zero-code-if-conf-init-failed branch March 30, 2023 15:41
@chenrui333 chenrui333 mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@id id id approved these changes

@savonarola savonarola savonarola left review comments

@thalesmg thalesmg thalesmg left review comments

@lafirest lafirest Awaiting requested review from lafirest lafirest is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zmstone @savonarola @id @thalesmg