Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): create directory before uploading #10300

Merged
merged 1 commit into from Mar 31, 2023

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Mar 30, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-9434

Fixes emqx/emqx-elixir-plugin#23

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg marked this pull request as ready for review March 30, 2023 20:52
@thalesmg thalesmg requested review from a team, lafirest and sstrigler as code owners March 30, 2023 20:52
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4568886047

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 41 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.007%) to 81.064%

Files with Coverage Reduction New Missed Lines %
apps/emqx_bridge/src/emqx_bridge.erl 1 91.2%
apps/emqx_gateway/src/mqttsn/emqx_sn_channel.erl 1 73.13%
apps/emqx_modules/src/emqx_delayed.erl 1 94.78%
apps/emqx/src/emqx_flapping.erl 1 85.11%
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_router_helper.erl 1 86.27%
apps/emqx/src/emqx_session.erl 1 87.65%
apps/emqx_connector/src/emqx_connector_jwt_worker.erl 2 92.54%
apps/emqx_resource/src/emqx_resource_buffer_worker_sup.erl 2 86.96%
apps/emqx/src/emqx_banned.erl 2 89.39%
Totals Coverage Status
Change from base Build 4566317424: 0.007%
Covered Lines: 25040
Relevant Lines: 30889

💛 - Coveralls

@thalesmg thalesmg merged commit 53d760e into emqx:master Mar 31, 2023
105 checks passed
@thalesmg thalesmg deleted the fix-plugin-upload-v50 branch March 31, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot start plugin
5 participants