feat(rule engine sql): enable both ' and " strings in FROM clause #10318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the rulesql dependency to version 1.5 instead of 1.4. The difference between these two versions is that strings surrounded by ' and " are supported in FROM clauses in version 1.5, but in version 1.4, only strings surrounded by " are supported. Fixes: https://emqx.atlassian.net/browse/EMQX-9243
kjellwinblad
force-pushed
the
kjell/feat/rule_engine_from_clause_support_both_string_types
branch
from
8aa5206
to
0e66eb5
Compare
ieQu1
approved these changes
Apr 5, 2023
thalesmg
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the rulesql dependency to version 1.5 instead of 1.4. The difference between these two versions is that strings surrounded by ' and " are supported in FROM clauses in version 1.5, but in version 1.4, only strings surrounded by " are supported.
Fixes:
https://emqx.atlassian.net/browse/EMQX-9243
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdfiles