Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rule_engine): test 'ok' results in one dedicated function #10328

Closed

Conversation

SergeTupchiy
Copy link
Contributor

@SergeTupchiy SergeTupchiy commented Apr 4, 2023

Summary

🤖 Generated by Copilot at 5d9439e

Improved metrics handling for rule actions in emqx_rule_runtime.erl. Extracted common logic to a new function and added a predicate for checking action results.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@SergeTupchiy SergeTupchiy force-pushed the refactor-rule-runtime-ok-result branch from 5d9439e to 9810c9f Compare April 5, 2023 13:56
@SergeTupchiy SergeTupchiy changed the base branch from release-50 to master April 5, 2023 13:56
@SergeTupchiy SergeTupchiy deleted the refactor-rule-runtime-ok-result branch April 5, 2023 18:21
@SergeTupchiy SergeTupchiy restored the refactor-rule-runtime-ok-result branch April 5, 2023 18:21
@SergeTupchiy SergeTupchiy reopened this Apr 5, 2023
@SergeTupchiy SergeTupchiy deleted the refactor-rule-runtime-ok-result branch April 5, 2023 18:31
@SergeTupchiy SergeTupchiy restored the refactor-rule-runtime-ok-result branch April 5, 2023 18:34
@SergeTupchiy SergeTupchiy deleted the refactor-rule-runtime-ok-result branch April 5, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant